Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

From: Vladimir Oltean
Date: Mon Oct 14 2019 - 06:46:42 EST


Hi Nishad,

On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkamdar@xxxxxxxxx> wrote:
>
> This patch corrects the SPDX License Identifier style
> in header files related to Distributed Switch Architecture
> drivers for NXP SJA1105 series Ethernet switch support.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Nishad Kamdar <nishadkamdar@xxxxxxxxx>
> ---

Your commit message has nothing to do with what you're fixing, but
whatever. The SPDX identifiers _are_ using C-like comments.

Acked-by: Vladimir Oltean <olteanv@xxxxxxxxx>

> drivers/net/dsa/sja1105/sja1105.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++--
> drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105.h b/drivers/net/dsa/sja1105/sja1105.h
> index 8681ff9d1a76..fb7a6fff643f 100644
> --- a/drivers/net/dsa/sja1105/sja1105.h
> +++ b/drivers/net/dsa/sja1105/sja1105.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
> * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> */
> #ifndef _SJA1105_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> index 740dadf43f01..4f64adb2d26a 100644
> --- a/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_dynamic_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> */
> #ifndef _SJA1105_DYNAMIC_CONFIG_H
> #define _SJA1105_DYNAMIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.h b/drivers/net/dsa/sja1105/sja1105_ptp.h
> index af456b0a4d27..c7e598fd1504 100644
> --- a/drivers/net/dsa/sja1105/sja1105_ptp.h
> +++ b/drivers/net/dsa/sja1105/sja1105_ptp.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> */
> #ifndef _SJA1105_PTP_H
> #define _SJA1105_PTP_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.h b/drivers/net/dsa/sja1105/sja1105_static_config.h
> index 7f87022a2d61..ee66fae6128b 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.h
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright (c) 2016-2018, NXP Semiconductors
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/* Copyright (c) 2016-2018, NXP Semiconductors
> * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> */
> #ifndef _SJA1105_STATIC_CONFIG_H
> diff --git a/drivers/net/dsa/sja1105/sja1105_tas.h b/drivers/net/dsa/sja1105/sja1105_tas.h
> index 0b803c30e640..c3ea7be52b9c 100644
> --- a/drivers/net/dsa/sja1105/sja1105_tas.h
> +++ b/drivers/net/dsa/sja1105/sja1105_tas.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - * Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2019, Vladimir Oltean <olteanv@xxxxxxxxx>
> */
> #ifndef _SJA1105_TAS_H
> #define _SJA1105_TAS_H
> --
> 2.17.1
>