Re: tcp: Checking a kmemdup() call in tcp_time_wait()

[Markus Elfring]

>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306
>>>> https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306
â

>> Can an other error reporting approach be nicer here?
>
> There is no error reported if kmemdup() has failed.

How do data from the Linux allocation failure report fit to this information?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=4f5cafb5cb8471e54afdc9054d973535614f7675#n878


> timewait is best effort.

How do you think about to return an error code like â-ENOMEMâ at this place?

Regards,
Markus