Re: [PATCH] drm/dp-mst: remove unused variable

[Sean Paul]

On Mon, Oct 14, 2019 at 8:53 AM Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
>
> The variable 'dev' is no longer used and the compiler rightly complains
> that it should be removed.
>
> ../drivers/gpu/drm/drm_dp_mst_topology.c: In function âdrm_atomic_get_mst_topology_stateâ:
> ../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable âdevâ [-Wunused-variable]
>   struct drm_device *dev = mgr->dev;
>                      ^~~
>
> Rework to remove the unused variable.
>
> Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Hi Anders,
Thank you for your patch! Manasi has already posted a patch for this:
https://patchwork.freedesktop.org/patch/335358/

It's reviewed, so we're just waiting for it to land.

Sean


> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9364e4f42975..9cccc5e63309 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
>  struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
>                                                                     struct drm_dp_mst_topology_mgr *mgr)
>  {
> -       struct drm_device *dev = mgr->dev;
> -
>         return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
>  }
>  EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
> --
> 2.20.1
>