Re: [PATCH 3/3] perf tools: Make 'struct map_shared' truly shared

From: Andi Kleen
Date: Mon Oct 14 2019 - 15:46:22 EST


> > We may need a COW operation for this (hopefully rare) case.
>
> so the jitted mmaps are inserted into the data file
> and processed during report where they can overload
> existing maps - thats detected before addition in:
>
> thread__insert_map
> map_groups__fixup_overlappings
> - which uses COW way -> map__clone(map, false);
> to create new map
>
> other fixups to maps are being done only for kernel maps,
> where we dont have a problem, because there's only one copy

I assume the same is true for /tmp/perf-* processing?

Thanks for looking into it.



-Andi