Re: [PATCH v1 0/5] perf report: Support sorting all blocks by cycles

[Jin, Yao]

On 10/14/2019 11:32 PM, Jiri Olsa wrote:
> On Tue, Oct 08, 2019 at 03:04:57PM +0800, Jin Yao wrote:
> > It would be useful to support sorting for all blocks by the
> > sampled cycles percent per block. This is useful to concentrate
> > on the globally busiest/slowest blocks.
> >
> > This patch series implements a new sort option "total_cycles" which
> > sorts all blocks by 'Sampled Cycles%'. The 'Sampled Cycles%' is
> > block sampled cycles aggregation / total sampled cycles
> >
> > For example,
> >
> > perf record -b ./div
> > perf report -s total_cycles --stdio
> >
> >   # To display the perf.data header info, please use --header/--header-only options.
> >   #
> >   #
> >   # Total Lost Samples: 0
> >   #
> >   # Samples: 2M of event 'cycles'
> >   # Event count (approx.): 2753248
> >   #
> >   # Sampled Cycles%  Sampled Cycles  Avg Cycles%  Avg Cycles                                              [Program Block Range]         Shared Object
> >   # ...............  ..............  ...........  ..........  .................................................................  ....................
> >   #
> >              26.04%            2.8M        0.40%          18                                             [div.c:42 -> div.c:39]                   div
> >              15.17%            1.2M        0.16%           7                                 [random_r.c:357 -> random_r.c:380]          libc-2.27.so
> >               5.11%          402.0K        0.04%           2                                             [div.c:27 -> div.c:28]                   div
> >               4.87%          381.6K        0.04%           2                                     [random.c:288 -> random.c:291]          libc-2.27.so
> >               4.53%          381.0K        0.04%           2                                             [div.c:40 -> div.c:40]                   div
> >               3.85%          300.9K        0.02%           1                                             [div.c:22 -> div.c:25]                   div
> >               3.08%          241.1K        0.02%           1                                           [rand.c:26 -> rand.c:27]          libc-2.27.so
> >               3.06%          240.0K        0.02%           1                                     [random.c:291 -> random.c:291]          libc-2.27.so
> >               2.78%          215.7K        0.02%           1                                     [random.c:298 -> random.c:298]          libc-2.27.so
> >               2.52%          198.3K        0.02%           1                                     [random.c:293 -> random.c:293]          libc-2.27.so
> >               2.36%          184.8K        0.02%           1                                           [rand.c:28 -> rand.c:28]          libc-2.27.so
> >               2.33%          180.5K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >               2.28%          176.7K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >               2.20%          168.8K        0.02%           1                                         [rand@plt+0 -> rand@plt+0]                   div
> >               1.98%          158.2K        0.02%           1                                 [random_r.c:388 -> random_r.c:388]          libc-2.27.so
> >               1.57%          123.3K        0.02%           1                                             [div.c:42 -> div.c:44]                   div
> >               1.44%          116.0K        0.42%          19                                 [random_r.c:357 -> random_r.c:394]          libc-2.27.so
> >   ......
> >
> > This patch series supports both stdio and tui. And also with the supporting
> > of --percent-limit.
> >
> > Jin Yao (5):
> >    perf util: Create new block.h/block.c for block related functions
> >    perf util: Count the total cycles of all samples
> >    perf report: Sort by sampled cycles percent per block for stdio
> >    perf report: Support --percent-limit for total_cycles
> >    perf report: Sort by sampled cycles percent per block for tui
>
> sry for delay, but I can no longer apply this
> could you please rebase?
>
> thanks,
> jirka

Hi Jiri,

Thanks a lot for reviewing the patch. I just sent out the v2 which had 
been rebased to perf/core branch.

Thanks
Jin Yao