Re: [RFC PATCH 6/6] ACPI/IORT: Drop code to set the PMCG software-defined model

[John Garry]

On 15/10/2019 04:06, Hanjun Guo wrote:
> > -/*
> > > - * PMCG model identifiers for use in smmu pmu driver. Please note
> > > - * that this is purely for the use of software and has nothing to
> > > - * do with hardware or with IORT specification.
> > > - */
> > > -#define IORT_SMMU_V3_PMCG_GENERIC        0x00000000 /* Generic SMMUv3 PMCG */
> > > -#define IORT_SMMU_V3_PMCG_HISI_HIP08     0x00000001 /* HiSilicon HIP08 PMCG */
> Since only HiSilicon platform has such erratum, and I think it works with
> both old version of firmware, I'm fine with removing this erratum framework.

Yeah, seems a decent change on its own, even without the SMMU PMCG 
driver changes.

But we still need to check on patch "[PATCH RFC 2/6] iommu/arm-smmu-v3: 
Record IIDR in arm_smmu_device structure" to progress any of this.

Will, Robin, Any opinion on that patch?

https://lore.kernel.org/linux-iommu/1569854031-237636-1-git-send-email-john.garry@xxxxxxxxxx/T/#m1e24771a23ee5426ec94ca2c4ec572642c155a77

> Acked-by: Hanjun Guo <guohanjun@xxxxxxxxxx>

Cheers,
John

> Thanks
> Hanjun
>
>
> .