Re: [PATCH v5 05/14] software node: clean up property_copy_string_array()

From: Andy Shevchenko
Date: Tue Oct 15 2019 - 08:07:32 EST


On Fri, Oct 11, 2019 at 04:07:12PM -0700, Dmitry Torokhov wrote:
> Because property_copy_string_array() stores the newly allocated pointer in the
> destination property, we have an awkward code in property_entry_copy_data()
> where we fetch the new pointer from dst.

I don't see a problem in this function.

Rather 'awkward code' is a result of use property_set_pointer() which relies on
data type.

> Let's change property_copy_string_array() to return pointer and rely on the
> common path in property_entry_copy_data() to store it in destination structure.

--
With Best Regards,
Andy Shevchenko