Re: clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll()

[Tomasz Figa]

Hi Markus,

2019å10æ12æ(å) 23:17 Markus Elfring <Markus.Elfring@xxxxxx>:
>
> Hello,
>
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function â_samsung_clk_register_pllâ contains also a call
> of the function âkmemdupâ.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/samsung/clk-pll.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1275
> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/samsung/clk-pll.c#L1275

Thanks for the report.

>
> * Do you find the usage of the format string â%s: could not allocate
>   rate table for %s\nâ still appropriate at this place?

Yes, AFAICT there is nothing wrong with that format string.

>
> * Is there a need to adjust the error handling here?

No, there isn't much that can be done if we fail the allocation at
such an early stage.

That said, there is no need to print any warnings or error messages on
allocation failure, so technically they could be removed. It doesn't
really give us anything in case of existing code, though, and only
makes a potential for merge conflicts, so I'd just leave it alone.

Best regards,
Tomasz