Re: [v2,1/2] dt-bindings: i2c: add property idle-state

[Peter Rosin]

On 2019-10-15 06:48, Biwen Li wrote:
> This adds property idle-state
> 
> Signed-off-by: Biwen Li <biwen.li@xxxxxxx>
> ---
> Change in v2:
> 	- update subject and description
> 	- add property idle-state
> 
>  Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 30ac6a60f041..2c7875d338fb 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -34,6 +34,7 @@ Optional Properties:
>      - first cell is the pin number
>      - second cell is used to specify flags.
>      See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +  - idle-state: Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
>  
>  Example:
>  
> 

As per my comments on the code, you should mention that idle-state, if present,
overrides i2c-mux-idle-disconnect. I also think you should keep idle-state
and i2c-mux-idle-disconnect right next to each other.

Cheers,
Peter