Re: [PATCH v9 13/28] um: Annotate data appropriately
From: Richard Weinberger
Date: Tue Oct 15 2019 - 11:37:43 EST
----- UrsprÃngliche Mail -----
> Von: "Jiri Slaby" <jslaby@xxxxxxx>
> An: bp@xxxxxxxxx
> CC: tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, "linux-kernel"
> <linux-kernel@xxxxxxxxxxxxxxx>, "Jiri Slaby" <jslaby@xxxxxxx>, "Jeff Dike" <jdike@xxxxxxxxxxx>, "richard"
> <richard@xxxxxx>, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx, user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx
> Gesendet: Freitag, 11. Oktober 2019 13:50:53
> Betreff: [PATCH v9 13/28] um: Annotate data appropriately
> Use the new SYM_DATA_START and SYM_DATA_END_LABEL macros for vdso_start.
>
> We get:
> 0000 2376 OBJECT GLOBAL DEFAULT 4 vdso_start
> 0948 0 OBJECT GLOBAL DEFAULT 4 vdso_end
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx
> ---
> arch/x86/um/vdso/vdso.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index a4a3870dc059..a6eaf293a73b 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,11 +1,11 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #include <linux/init.h>
> +#include <linux/linkage.h>
>
> __INITDATA
>
> - .globl vdso_start, vdso_end
> -vdso_start:
> +SYM_DATA_START(vdso_start)
> .incbin "arch/x86/um/vdso/vdso.so"
> -vdso_end:
> +SYM_DATA_END_LABEL(vdso_start, SYM_L_GLOBAL, vdso_end)
Acked-by: Richard Weinberger <richard@xxxxxx>
Thanks,
//richard