Re: [PATCH v5 3/6] timekeeping: Add clocksource to system_time_snapshot

From: Paolo Bonzini
Date: Tue Oct 15 2019 - 18:35:31 EST


On 15/10/19 22:12, Thomas Gleixner wrote:
> @@ -91,6 +96,7 @@ struct clocksource {
> const char *name;
> struct list_head list;
> int rating;
> + enum clocksource_ids id;

Why add a global id? ARM can add it to archdata similar to how x86 has
vclock_mode. But I still think the right thing to do is to include the
full system_counterval_t in the result of ktime_get_snapshot. (More in
a second, feel free to reply to the other email only).

Paolo