Re: [PATCH -next] clk: sprd: use devm_platform_ioremap_resource() to simplify code

[Baolin Wang]

Hi,

On Tue, 15 Oct 2019 at 22:22, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

We already posted a patch to do this, thanks anyway.
https://lore.kernel.org/patchwork/patch/1136894/

> ---
>  drivers/clk/sprd/common.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> index 9d56eac..3718696 100644
> --- a/drivers/clk/sprd/common.c
> +++ b/drivers/clk/sprd/common.c
> @@ -42,7 +42,6 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
>         void __iomem *base;
>         struct device_node *node = pdev->dev.of_node;
>         struct regmap *regmap;
> -       struct resource *res;
>
>         if (of_find_property(node, "sprd,syscon", NULL)) {
>                 regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
> @@ -51,8 +50,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
>                         return PTR_ERR(regmap);
>                 }
>         } else {
> -               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -               base = devm_ioremap_resource(&pdev->dev, res);
> +               base = devm_platform_ioremap_resource(pdev, 0);
>                 if (IS_ERR(base))
>                         return PTR_ERR(base);
>
> --
> 2.7.4
>
>


-- 
Baolin Wang
Best Regards