Re: [PATCH] KVM: X86: Make fpu allocation a common function

[Xiaoyao Li]

On 10/15/2019 5:28 PM, Paolo Bonzini wrote:
> On 14/10/19 18:58, Vitaly Kuznetsov wrote:
> > Xiaoyao Li <xiaoyao.li@xxxxxxxxx> writes:
> >
> > > They are duplicated codes to create vcpu.arch.{user,guest}_fpu in VMX
> > > and SVM. Make them common functions.
> > >
> > > No functional change intended.
> > Would it rather make sense to move this code to
> > kvm_arch_vcpu_create()/kvm_arch_vcpu_destroy() instead?
>
> user_fpu could be made percpu too...  That would save a bit of memory
> for each vCPU.  I'm holding on Xiaoyao's patch because a lot of the code
> he's touching would go away then.

Sorry, I don't get clear your attitude.
Do you mean the generic common function is not so better that I'd better 
to implement the percpu solution?

> Paolo