Re: clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll()

From: Markus Elfring
Date: Wed Oct 16 2019 - 02:25:01 EST

>> Would you like to adjust such exception handling another bit?
> Nope.
> The big difference is that clocks rely heavily on their names to establish
> the clock tree parentship. So the PLL cannot work without the name

This error situation got a specific reaction.

> but can provide some means of functionality without the rate-table
> especially as bootloaders do generally initialize a PLL to some form of
> sane frequency.

I imagine that a choice is available here for the error handling strategy.

* Return âERR_PTR(-ENOMEM)â as a strict response like in the other error case.

* Fix the setting âpll->rate_countâ at least (to be a bit more tolerant).
Would any system users wonder then about the availability of only
a single frequency (instead of possibly expected alternatives)?