Re: [PATCH] PCI: sysfs: remove pci_bridge_groups and pcie_dev_groups

[Ben Dooks]

On 16/10/2019 07:28, Christoph Hellwig wrote:
> On Tue, Oct 15, 2019 at 03:00:59PM +0100, Ben Dooks wrote:
> > The pci_bridge_groups and pcie_dev_groups objects are
> > not exported and not used at-all, so remove them to
> > fix the following warnings from sparse:
> >
> > drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static?
> > drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static?
>
> But now pci_bridge_group is unused, and if you remove that the
> attributes, etc..

Hmm, didn't get a warning for that. I'll go check.


--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html