Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

From: Code Kipper
Date: Wed Oct 16 2019 - 04:41:48 EST


On Wed, 16 Oct 2019 at 10:04, Maxime Ripard <mripard@xxxxxxxxxx> wrote:
>
> On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekipper@xxxxxxxxx wrote:
> > From: Marcus Cooper <codekipper@xxxxxxxxx>
> >
> > On the newer SoCs the offset is used to set the mode of the
> > connection. As it is to be used elsewhere then it makes sense
> > to move it to the main structure.
>
> Elsewhere where, and to do what?
Thanks...How does this sound?

As it is to be used to set the same offset for each TX data channel in use
during multi-channel audio then let's move it to the main structure.

BR,
CK
>
> Maxime