Re: [PATCH] Fix reading support of the 1-4-4-DTR read-mode from the wrong bit of the SFDP table which is part of the linux-imx fork located in the following repo: https://source.codeaurora.org/external/imx/linux-imx/?h=imx_4.14.98_2.1.0

From: Vignesh Raghavendra
Date: Wed Oct 16 2019 - 04:42:03 EST




On 11/09/19 12:24 PM, Christoph Fink wrote:
> From: Christoph Fink <fink.christoph@xxxxxxxxx>
>

This patch is not against mainline kernel. There is no support for DTR
mode in kernel yet. Below hunk is not even present in the spi-nor.c.

For future submissions:
Subject line should be one line summary of the patch starting with
prefix "mtd: spi-nor:" (hint: run git log on file to know the format)
and commit message should have detailed description of the patch

Regards
Vignesh


> Signed-off-by: Christoph Fink <fink.christoph@xxxxxxxxx>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 8cc4b04..7fd52fa 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2089,7 +2089,7 @@ static const struct sfdp_bfpt_read sfdp_bfpt_reads[] = {
> /* Fast Read 1-4-4-DTR */
> {
> SNOR_HWCAPS_READ_1_4_4_DTR,
> - BFPT_DWORD(1), BIT(21), /* Supported bit */
> + BFPT_DWORD(1), BIT(19), /* Supported bit */
> BFPT_DWORD(3), 0, /* Settings */
> SNOR_PROTO_1_4_4_DTR,
> },
>

--
Regards
Vignesh