Re: [PATCH] staging: media: make use of devm_platform_ioremap_resource

[Laurent Pinchart]

Hello Hariprasad,

Thank you for the patch.

As the patch only touches the omap4iss driver, you could have made the
subject line a bit more specific, for instance "staging: media:
omap4iss: Use devm_platform_ioremap_resource". No big deal though.

On Tue, Oct 08, 2019 at 12:25:51PM +0530, hariprasadKelamhariprasad.kelam@xxxxxxxxx wrote:
> From: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
> 
> fix below issue reported by coccicheck
> drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use
> devm_platform_ioremap_resource for iss -> regs [ res ]
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>

The change looks good to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

and applied to my tree for v5.5.

> ---
>  drivers/staging/media/omap4iss/iss.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index 1a966cb..6fb60b5 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -908,11 +908,7 @@ static int iss_map_mem_resource(struct platform_device *pdev,
>  				struct iss_device *iss,
>  				enum iss_mem_resources res)
>  {
> -	struct resource *mem;
> -
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, res);
> -
> -	iss->regs[res] = devm_ioremap_resource(iss->dev, mem);
> +	iss->regs[res] = devm_platform_ioremap_resource(pdev, res);
>  
>  	return PTR_ERR_OR_ZERO(iss->regs[res]);
>  }

-- 
Regards,

Laurent Pinchart