Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

[Masahiro Yamada]

Hi Andrew,

Could you pick up this to akpm tree?
https://lore.kernel.org/patchwork/patch/1089856/

I believe this is correct, and a good clean-up.

I pinged the DT maintainers, but they did not respond.

Thanks.




On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
> > <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > >
> > > Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
> > >
> > > <linux/kernel.h> pulls in a lots of broat.
> > >
> > > Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
> > > macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
> > > <linux/limits.h>.
> > >
> > > This saves including dozens of headers.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > > ---
> >
> > ping?
>
> ping x2.
>
>
>
>
> >
> >
> > >  include/linux/libfdt_env.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> > > index edb0f0c30904..2231eb855e8f 100644
> > > --- a/include/linux/libfdt_env.h
> > > +++ b/include/linux/libfdt_env.h
> > > @@ -2,7 +2,7 @@
> > >  #ifndef LIBFDT_ENV_H
> > >  #define LIBFDT_ENV_H
> > >
> > > -#include <linux/kernel.h>      /* For INT_MAX */
> > > +#include <linux/limits.h>      /* For INT_MAX */
> > >  #include <linux/string.h>
> > >
> > >  #include <asm/byteorder.h>
> > > --
> > > 2.17.1
> > >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada