Re: [PATCH 23/36] ARM: s3c: move s3cmci pinctrl handling into board files

[Linus Walleij]

On Thu, Oct 10, 2019 at 10:47 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> Rather than call the internal s3c_gpio_cfgall_range() function
> through a platform header, move the code into the set_power
> callback that is already exported by the board, and add
> a default implementation.
>
> In DT mode, the code already does not set the pin config,
> so nothing changes there.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

It looks good:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

It would feel better if someone was actually testing it on these
boards. I see Ben is listed as maintainer so I bet he will
pull the board out :)

Yours,
Linus Walleij