Re: [PATCH v4 2/4] clocksource/drivers/timer-of: Use unique device name instead of timer

From: Rob Herring
Date: Wed Oct 16 2019 - 11:02:19 EST


On Wed, Oct 16, 2019 at 9:52 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> If a hardware-specific driver does not provide a name, the timer-of core
> falls back to device_node.name. Due to generic DT node naming policies,
> that name is almost always "timer", and thus doesn't identify the actual
> timer used.
>
> Fix this by using device_node.full_name instead, which includes the unit
> addrees.
>
> Example impact on /proc/timer_list:
>
> -Clock Event Device: timer
> +Clock Event Device: timer@fcfec400
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v4:
> - New.
> ---
> drivers/clocksource/timer-of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Good. One less device_node.name pointer use to get rid of. I want to
drop it from the struct and stop storing both node name strings.

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Rob