Re: [PATCH v2] tpm/tpm_ftpm_tee: add shutdown call back

[Jarkko Sakkinen]

On Mon, Oct 14, 2019 at 04:21:35PM -0400, Pavel Tatashin wrote:
> add shutdown call back to close existing session with fTPM TA
> to support kexec scenario.

Sentences start in English with a capital letter :-)

> 
> Signed-off-by: Thirupathaiah Annapureddy <thiruan@xxxxxxxxxxxxx>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> ---
>  drivers/char/tpm/tpm_ftpm_tee.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 6640a14dbe48..ad16ea555e97 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -328,6 +328,19 @@ static int ftpm_tee_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +/**
> + * ftpm_tee_shutdown - shutdown the TPM device

A function name has to have parentheses in kdoc. I know this not
consistently done in the subsystem ATM but this is what is documented
here:

https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt

/Jarkko