Re: [PATCH v3 2/3] selftests/livepatch: Make dynamic debug setup and restore generic
From: Kamalesh Babulal
Date: Wed Oct 16 2019 - 13:10:38 EST
On 10/16/19 5:03 PM, Miroslav Benes wrote:
> From: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
>
> Livepatch selftests currently save the current dynamic debug config and
> tweak it for the selftests. The config is restored at the end. Make the
> infrastructure generic, so that more variables can be saved and
> restored.
>
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
> ---
> .../testing/selftests/livepatch/functions.sh | 22 +++++++++++--------
> .../selftests/livepatch/test-callbacks.sh | 2 +-
> .../selftests/livepatch/test-livepatch.sh | 2 +-
> .../selftests/livepatch/test-shadow-vars.sh | 2 +-
A minor nit pick, should the README also updated with the setup_config()?
--
Kamalesh