Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc
From: Tuowen Zhao
Date: Wed Oct 16 2019 - 13:58:55 EST
On Wed, 2019-10-16 at 12:56 +0000, Luis Chamberlain wrote:
> Indeed, can you add that? If you are not comfortable the way to leave
> behind lazy architectures is the HAS_FOO feature and then have your
> driver require that or depend on the archs that support this. This
> allows non-lazy architecturess to move forward with life.
>
> Luis
Upon close examination, the issue seems easy to fix. Going to submit a
new set shortly.
sparc64 and hexagon don't have ioremap_uc defined. Hexagon also doesn't
have ioremap_wc but didn't report an issue before so devm_ioremap won't
have an problem.
Interestingly tho, majority of the archs include <asm-generic/io.h>,
thus having prototypes. These two archs and a few others don't. I'm
wondering if including the prototypes is actually the recommended
practice.
Tuowen