Re: [PATCH v3 3/3] selftests/livepatch: Test interaction with ftrace_enabled

[Joe Lawrence]

On 10/16/19 1:06 PM, Kamalesh Babulal wrote:
> On 10/16/19 5:03 PM, Miroslav Benes wrote:
> > From: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> >
> > Since livepatching depends upon ftrace handlers to implement "patched"
> > code functionality, verify that the ftrace_enabled sysctl value
> > interacts with livepatch registration as expected.  At the same time,
> > ensure that ftrace_enabled is set and part of the test environment
> > configuration that is saved and restored when running the selftests.
> >
> > Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> > Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
>
> [...]
> > diff --git a/tools/testing/selftests/livepatch/test-ftrace.sh b/tools/testing/selftests/livepatch/test-ftrace.sh
> > new file mode 100755
> > index 000000000000..e2a76887f40a
> > --- /dev/null
> > +++ b/tools/testing/selftests/livepatch/test-ftrace.sh
>
> This test fails due to wrong file permissions, with the warning:
>
> # Warning: file test-ftrace.sh is not executable, correct this.
> not ok 4 selftests: livepatch: test-ftrace.sh

Hi Kamalesh,

Thanks for testing.  This error is weird as the git log says new file 
mode: 100755.  'git am' of Miroslav's patchset gives me a new 
test-ftrace.sh with "Access: (0775/-rwxrwxr-x)"  Did you apply the mbox 
directly or.. ?

-- Joe