Re: [PATCH 5.3 112/112] ASoC: sgtl5000: add ADC mute control

From: Greg Kroah-Hartman
Date: Wed Oct 16 2019 - 18:10:47 EST

On Wed, Oct 16, 2019 at 11:00:44PM +0100, Mark Brown wrote:
> On Wed, Oct 16, 2019 at 02:51:44PM -0700, Greg Kroah-Hartman wrote:
> > From: Oleksandr Suvorov <oleksandr.suvorov@xxxxxxxxxxx>
> >
> > commit 694b14554d75f2a1ae111202e71860d58b434a21 upstream.
> >
> > This control mute/unmute the ADC input of SGTL5000
> > using its CHIP_ANA_CTRL register.
> This seems like a new feature and not an obvious candidate for stable?

there was a long email from Richard that said:
Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute
outputs on probe"), which is e9f621efaebd in v5.3 replaced
snd_soc_component_write with snd_soc_component_update_bits and
therefore no longer cleared the MUTE_ADC flag. This caused the
ADC to stay muted and recording doesn't work any longer. This
patch fixes this problem by adding a Switch control for

That's why I took this. If this isn't true, I'll be glad to drop this.


greg k-h