Re: [PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting

From: Kuninori Morimoto
Date: Wed Oct 16 2019 - 19:50:59 EST



Hi

> Unlike other format-related DAI parameters, rdai->bit_clk_inv flag
> is not properly re-initialized when setting format for new stream
> processing. The inversion, if requested, is then applied not to default,
> but to a previous value, which leads to SCKP bit in SSICR register being
> set incorrectly.
> Fix this by re-setting the flag to its initial value, determined by format.
>
> Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior")
> Cc: Andrew Gabbasov <andrew_gabbasov@xxxxxxxxxx>
> Cc: Jiada Wang <jiada_wang@xxxxxxxxxx>
> Cc: Timo Wischer <twischer@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v3.17+
> Signed-off-by: Junya Monden <jmonden@xxxxxxxxxxxxxx>
> Signed-off-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>