Re: [PATCH 2/3] cpufreq: merge arm_big_little and vexpress-spc
From: Viresh Kumar
Date: Wed Oct 16 2019 - 22:39:43 EST
On 16-10-19, 12:03, Sudeep Holla wrote:
> arm_big_little cpufreq driver was designed as a generic big little
> driver that could be used by any platform and make use of bL switcher.
> Over years alternate solutions have be designed and merged to deal with
> bL/HMP systems like EAS.
> Also since no other driver made use of generic arm_big_little cpufreq
> driver except Vexpress SPC, we can merge them together as vexpress-spc
> driver used only on Vexpress TC2(CA15_CA7) platform.
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> MAINTAINERS | 5 +-
> drivers/cpufreq/Kconfig.arm | 12 +-
> drivers/cpufreq/Makefile | 2 -
> drivers/cpufreq/arm_big_little.c | 658 ------------------------
> drivers/cpufreq/arm_big_little.h | 43 --
> drivers/cpufreq/vexpress-spc-cpufreq.c | 661 ++++++++++++++++++++++++-
> 6 files changed, 652 insertions(+), 729 deletions(-)
> delete mode 100644 drivers/cpufreq/arm_big_little.c
> delete mode 100644 drivers/cpufreq/arm_big_little.h
The delta produced here is enormous probably because you copy/pasted things. I
am wondering if using git mv to rename arm_big_little.c and then move spc bits
into it will make this delta smaller to review ?