Re: [PATCH v3 4/5] kdb: Improve handling of characters from different input sources

From: Doug Anderson
Date: Thu Oct 17 2019 - 00:11:56 EST


On Mon, Oct 14, 2019 at 8:46 AM Daniel Thompson
<daniel.thompson@xxxxxxxxxx> wrote:
> Currently if an escape timer is interrupted by a character from a
> different input source then the new character is discarded and the
> function returns '\e' (which will be discarded by the level above).
> It is hard to see why this would ever be the desired behaviour.
> Fix this to return the new character rather than the '\e'.
> This is a bigger refactor than might be expected because the new
> character needs to go through escape sequence detection.
> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> ---
> kernel/debug/kdb/kdb_io.c | 39 +++++++++++++++++++--------------------
> 1 file changed, 19 insertions(+), 20 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>