RE: [PATCH] arm64: defconfig: add JFFS FS support in defconfig

[Ooi, Joyce]

> -----Original Message-----
> From: Vladimir Murzin [mailto:vladimir.murzin@xxxxxxx]
> Sent: Wednesday, October 16, 2019 7:46 PM
> To: Ooi, Joyce <joyce.ooi@xxxxxxxxx>; Catalin Marinas
> <catalin.marinas@xxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Dinh Nguyen
> <dinguyen@xxxxxxxxxx>
> Cc: Tan, Ley Foon <ley.foon.tan@xxxxxxxxx>; Anson Huang
> <Anson.Huang@xxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Ong, Hean Loong
> <hean.loong.ong@xxxxxxxxx>; See, Chin Liang <chin.liang.see@xxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; Maxime Ripard <mripard@xxxxxxxxxx>; Bjorn
> Andersson <bjorn.andersson@xxxxxxxxxx>; Marcin Juszkiewicz
> <marcin.juszkiewicz@xxxxxxxxxx>; Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>;
> Olof Johansson <olof@xxxxxxxxx>; Leonard Crestez
> <leonard.crestez@xxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] arm64: defconfig: add JFFS FS support in defconfig
> 
> On 10/16/19 10:35 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@xxxxxxxxx>
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y  #
> CONFIG_DEBUG_PREEMPT is
> > not set  # CONFIG_FTRACE is not set  CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n
>                                    ^^^^
> This is incorrect syntax for disabling config option. Correct one is
> 
> # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
Okay, will do that.

> 
> However, it looks to me you want to remove it from defconfig rather than force
> it to be unset.
> 
> Cheers
> Vladimir