Re: [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane()

[Ben Dooks]

On 16/10/2019 21:28, David Miller wrote:
> From: "Ben Dooks (Codethink)" <ben.dooks@xxxxxxxxxxxxxxx>
> Date: Wed, 16 Oct 2019 09:22:05 +0100
>
> > The stmmac_pcs_ctrl_ane() expects a register address as
> > argument 1, but for some reason the mac_device_info is
> > being passed.
> >
> > Fix the warning (and possible bug) from sparse:
> >
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    expected void [noderef] <asn:2> *ioaddr
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    got struct mac_device_info *hw
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
>
> I'm still reviewing this but FYI you did not have to send this
> twice.

Yes, I accidentally sent the wrong patch out (already apologised
on the re-send as I noticed it about 10 minutes after sending).

--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html