Re: [PATCH 2/2] ARM: dts: at91: add a common kizbox2 dtsi file

[Thomas Petazzoni]

Hello Kamel,

On Thu, 17 Oct 2019 10:54:05 +0200
Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> wrote:

> There are three different boards available depending on the PCB
> (3 antennas support and several revison). Add a dtsi file to share
> common binding between all kizbox2 boards.
> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
> Signed-off-by: KÃvin RAYMOND <k.raymond@xxxxxxxxxxx>
> Signed-off-by: Mickael GARDET <m.gardet@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/Makefile                 |   6 +-
>  arch/arm/boot/dts/at91-kizbox.dts          | 173 +++++++-------

The changes to this file (change to use phandles) seem unrelated to the
current patch, unless I'm missing something.

>  arch/arm/boot/dts/at91-kizbox2-0.dts       |  17 ++
>  arch/arm/boot/dts/at91-kizbox2-1.dts       |  22 ++
>  arch/arm/boot/dts/at91-kizbox2-2.dts       |  26 +++
>  arch/arm/boot/dts/at91-kizbox2-3.dts       |  30 +++
>  arch/arm/boot/dts/at91-kizbox2-rev2.dts    |  34 +++
>  arch/arm/boot/dts/at91-kizbox2.dts         | 244 -------------------
>  arch/arm/boot/dts/at91-kizbox2_common.dtsi | 258 +++++++++++++++++++++

"-" seems to be a much more common separator for DT names, including in
this file, so what about at91-kizbox2-common.dtsi ?

> +// WMBUS (inverted with IO in the latest schematic)

I am not sure C++ comments are common in Device Tree files.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com