[PATCH v3 4/5] exit: use pid_has_task() in do_wait()
From: Christian Brauner
Date: Thu Oct 17 2019 - 06:19:23 EST
Replace hlist_empty() with the new pid_has_task() helper which is more
idiomatic, easier to grep for, and unifies how callers perform this check.
Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>
---
/* pidfd selftests */
passed
/* v1 */
patch not present
/* v2 */
Link: https://lore.kernel.org/r/20191016153606.2326-4-christian.brauner@xxxxxxxxxx
patch introduced
/* v3 */
- Oleg Nesterov <oleg@xxxxxxxxxx>:
- s/task_alive/pid_has_task/
---
kernel/exit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index a46a50d67002..f2d20ab74422 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1457,7 +1457,7 @@ static long do_wait(struct wait_opts *wo)
*/
wo->notask_error = -ECHILD;
if ((wo->wo_type < PIDTYPE_MAX) &&
- (!wo->wo_pid || hlist_empty(&wo->wo_pid->tasks[wo->wo_type])))
+ (!wo->wo_pid || !pid_has_task(wo->wo_pid, wo->wo_type)))
goto notask;
set_current_state(TASK_INTERRUPTIBLE);
--
2.23.0