Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static

[Andreas Gruenbacher]

On Thu, Oct 17, 2019 at 1:42 PM Andrew Price <anprice@xxxxxxxxxx> wrote:
> On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> > The gfs2_fs_parameters is not used outside the unit
> > it is declared in, so make it static.
> >
> > Fixes the following sparse warning:
> >
> > fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> > ---
> > Cc: Bob Peterson <rpeterso@xxxxxxxxxx>
> > Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> > Cc: cluster-devel@xxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> >   fs/gfs2/ops_fstype.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> > index 681b44682b0d..ebdef1c5f580 100644
> > --- a/fs/gfs2/ops_fstype.c
> > +++ b/fs/gfs2/ops_fstype.c
> > @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> >       {}
> >   };
> >
> > -const struct fs_parameter_description gfs2_fs_parameters = {
> > +static const struct fs_parameter_description gfs2_fs_parameters = {
> >       .name = "gfs2",
> >       .specs = gfs2_param_specs,
> >       .enums = gfs2_param_enums,
> >
>
> Looks good to me.

Andy, I've added a reviewed-by tag for you and pushed this to for-next.

Thanks,
Andreas