Re: [PATCH] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema

[Benjamin GAIGNARD]

On 10/17/19 3:06 PM, Alexandre Torgue wrote:
> Hi Benjamin
>
> On 10/17/19 2:41 PM, Benjamin Gaignard wrote:
>> Convert the STM32 watchdog binding to DT schema format using json-schema
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
>> ---
>> Â .../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 -----------
>> Â .../bindings/watchdog/st,stm32-iwdg.yamlÂÂÂÂÂÂÂÂÂÂ | 54 
>> ++++++++++++++++++++++
>> Â 2 files changed, 54 insertions(+), 26 deletions(-)
>> Â delete mode 100644 
>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>> Â create mode 100644 
>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt 
>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>> deleted file mode 100644
>> index d8f4430b0a13..000000000000
>> --- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
>> +++ /dev/null
>> @@ -1,26 +0,0 @@
>> -STM32 Independent WatchDoG (IWDG)
>> ----------------------------------
>> -
>> -Required properties:
>> -- compatible: Should be either:
>> -Â - "st,stm32-iwdg"
>> -Â - "st,stm32mp1-iwdg"
>> -- reg: Physical base address and length of the registers set for the 
>> device
>> -- clocks: Reference to the clock entry lsi. Additional pclk clock entry
>> -Â is required only for st,stm32mp1-iwdg.
>> -- clock-names: Name of the clocks used.
>> -Â "lsi" for st,stm32-iwdg
>> -Â "lsi", "pclk" for st,stm32mp1-iwdg
>> -
>> -Optional Properties:
>> -- timeout-sec: Watchdog timeout value in seconds.
>> -
>> -Example:
>> -
>> -iwdg: watchdog@40003000 {
>> -ÂÂÂ compatible = "st,stm32-iwdg";
>> -ÂÂÂ reg = <0x40003000 0x400>;
>> -ÂÂÂ clocks = <&clk_lsi>;
>> -ÂÂÂ clock-names = "lsi";
>> -ÂÂÂ timeout-sec = <32>;
>> -};
>> diff --git 
>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml 
>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>> new file mode 100644
>> index 000000000000..edec96d53e6b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
>> +
>> +maintainers:
>> +Â - Yannick Fertre <yannick.fertre@xxxxxx>
>
> Yannick is still working on this driver ?

That is a good question.

Rob, can we use the STM32 dedicated mailing list address for this 
mainteners field ?

maintainers:

- linux STM32 <linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>

Regards,

Benjamin

>
>> +
>> +allOf:
>> +Â - $ref: "watchdog.yaml#"
>> +
>> +properties:
>> +Â compatible:
>> +ÂÂÂ enum:
>> +ÂÂÂÂÂ - st,stm32-iwdg
>> +ÂÂÂÂÂ - st,stm32mp1-iwdg
>> +
>> +Â reg:
>> +ÂÂÂ maxItems: 1
>> +
>> +Â clocks:
>> +ÂÂÂ items:
>> +ÂÂÂÂÂ - description: Low speed clock
>> +ÂÂÂÂÂ - description: Optional peripheral clock
>> +ÂÂÂ minItems: 1
>> +ÂÂÂ maxItems: 2
>> +
>> +Â clock-names:
>> +ÂÂÂ items:
>> +ÂÂÂÂÂ enums: [ lsi, pclk ]
>> +ÂÂÂ minItems: 1
>> +ÂÂÂ maxItems: 2
>> +
>> +required:
>> +Â - compatible
>> +Â - reg
>> +Â - clocks
>> +Â - clock-names
>> +
>> +examples:
>> +Â - |
>> +ÂÂÂ #include <dt-bindings/clock/stm32mp1-clks.h>
>> +ÂÂÂ watchdog@5a002000 {
>> +ÂÂÂÂÂ compatible = "st,stm32mp1-iwdg";
>> +ÂÂÂÂÂ reg = <0x5a002000 0x400>;
>> +ÂÂÂÂÂ clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
>> +ÂÂÂÂÂ clock-names = "pclk", "lsi";
>> +ÂÂÂÂÂ timeout-sec = <32>;
>> +ÂÂÂ };
>> +
>> +...
>>