Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel

[Rob Herring]

On Wed, Oct 16, 2019 at 09:55:11AM -0500, Adam Ford wrote:
> On Wed, Oct 16, 2019 at 9:40 AM Laurent Pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> >
> > Hi Adam,
> >
> > Thank you for the patch.
> >
> > On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote:
> > > This patch adds documentation of device tree bindings for the WVGA panel
> > > Logic PD Type 28 display.
> > >
> > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> > > ---
> > > V5:  Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k
> > > V4:  Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1
> > > V3:  Correct build errors from 'make dt_binding_check'
> > > V2:  Use YAML instead of TXT for binding
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
> > > new file mode 100644
> > > index 000000000000..2834287b8d88
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
> > > @@ -0,0 +1,42 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel
> > > +
> > > +maintainers:
> > > +  - Adam Ford <aford173@xxxxxxxxx>
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: logicpd,type28
> > > +
> > > +  power-supply: true
> > > +  enable-gpios: true
> > > +  backlight: true
> > > +  port: true
> > > +
> > > +required:
> > > +  - compatible
> >
> > Should the port be required too ? Apart from that,
> 
> I supposed that's true, but I used ampire,am-480272h3tmqw-t01h.yaml as
> the example, and it doesn't list it as a required item.
> Is there anything else I need to address?  I feel like I'm trying to
> hit a moving target.

'port' can be omitted because the panel can be a child node of 
the display controller instead. That's decided by the display controller 
binding, not the panel binding.

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Rob