Re: [PATCH v3 1/7] PM/Domains: Add support for retrieving genpd performance states information
From: Thara Gopinath
Date: Thu Oct 17 2019 - 12:11:23 EST
On 10/17/2019 04:49 AM, Ulf Hansson wrote:
> On Wed, 16 Oct 2019 at 21:37, Thara Gopinath <thara.gopinath@xxxxxxxxxx> wrote:
>>
>> Add two new APIs in the genpd framework,
>> dev_pm_genpd_get_performance_state to return the current performance
>> state of a power domain and dev_pm_genpd_performance_state_count to
>> return the total number of performance states supported by a
>> power domain. Since the genpd framework does not maintain
>> a count of number of performance states supported by a power domain,
>> introduce a new callback(.get_performance_state_count) that can be used
>> to retrieve this information from power domain drivers.
>>
>> These APIs are added to aid the implementation of a power domain as
>> a warming device. Linux kernel cooling device framework(into which
>> warming device can be plugged in) requires during initialization to be
>> provided with the maximum number of states that can be supported. When
>> a power domain acts as a warming device, the max state is the max number
>> of perfomrance states supported by the power domain. The cooling
>> device framework implements API to retrieve the current state of the
>> cooling device. This in turn translates to the current performance
>> state of the power domain.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx>
>
> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>
Thanks Ulf! Do you think this patch be merged separate from the series.
Then I can drop it from the series.
--
Warm Regards
Thara