Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script

From: Marc Zyngier
Date: Thu Oct 17 2019 - 12:13:55 EST


On 2019-10-17 15:22, Alexandre Belloni wrote:
While it is useful for new drivers to use devm_platform_ioremap_resource,
this script is currently used to spam maintainers, often updating very old
drivers. The net benefit is the removal of 2 lines of code in the driver
but the review load for the maintainers is huge. As of now, more that 560
patches have been sent, some of them obviously broken, as in:


https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@xxxxxxxxxxx/

Remove the script to reduce the spam.

Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

I think part of the issue is that the script reports a WARNING for something
that is definitely correct code, and could instead be simply toned down.

Anyway, FWIW:

Acked-by: Marc Zyngier <maz@xxxxxxxxxx>

M.
--
Jazz is not dead. It just smells funny...