Re: [PATCH v3] tpm/tpm_ftpm_tee: add shutdown call back

From: Sasha Levin
Date: Thu Oct 17 2019 - 14:06:48 EST


On Thu, Oct 17, 2019 at 07:22:51PM +0300, Jarkko Sakkinen wrote:
On Wed, Oct 16, 2019 at 12:31:14PM -0400, Pavel Tatashin wrote:
Add shutdown call back to close existing session with fTPM TA
to support kexec scenario.

Add parentheses to function names in comments as specified in kdoc.

Signed-off-by: Thirupathaiah Annapureddy <thiruan@xxxxxxxxxxxxx>
Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>

LGTM

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

I have no means to test this though. It still needs a tested-by.

We've been running this patch internally for the past few months,
testing kexec scenarios, so I guess it could have mine :)

Tested-by: Sasha Levin <sashal@xxxxxxxxxx>

--
Thanks,
Sasha