Re: [PATCH 10/10] of/device: Don't NULLify match table in of_match_device() with CONFIG_OF=n
From: Stephen Boyd
Date: Thu Oct 17 2019 - 16:48:11 EST
Quoting Rob Herring (2019-10-17 13:24:23)
> On Thu, Oct 17, 2019 at 12:48 PM Frank Rowand <frowand.list@xxxxxxxxx> wrote:
> > On 10/04/2019 16:43, Stephen Boyd wrote:
> > > This effectively reverts 1db73ae39a97 ("of/device: Nullify match table
> > > in of_match_device() for CONFIG_OF=n") because that commit makes it more
> > > surprising to users of this API that the arguments may never be
> > > referenced by any code. This is because the pre-processor will replace
> > > the argument with NULL and then the match table will be left unreferenced
> > > by any code but the compiler optimizer doesn't know to drop it. This can
> > > lead to compilers warning that match tables are unused, when we really
> > > want to pass the match table to the API but have the compiler see that
> > > it's all inlined and not used and then drop the match table while
> > > silencing the warning. We're being too smart here and not giving the
> > > compiler the chance to do dead code elimination.
> > >
> > > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > > Cc: Frank Rowand <frowand.list@xxxxxxxxx>
> > > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > > ---
> > >
> > > Please ack or pick for immediate merge so the last patch can be merged.
> As this one is the last patch, I guess you don't want it picked up by itself.
> It seems everyone has acked rather than applying. Do you want me to
> take the series?
It would be great if you could take the series.
Mark applied the ASoC and spi patches. I guess you can try to see if
those merged into mainline and then base on top, or just apply the same
patches on your tree and let the duplicates drop out in the merge path.