Re: [PATCH v2 19/33] platform/x86: asus-laptop: Use pr_warn instead of pr_warning

From: Andy Shevchenko
Date: Fri Oct 18 2019 - 03:52:15 EST


On Fri, Oct 18, 2019 at 6:19 AM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
>
> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
> pr_warning"), removing pr_warning so all logging messages use a
> consistent <prefix>_warn style. Let's do it.

Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Cc: Corentin Chary <corentin.chary@xxxxxxxxx>
> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> ---
> drivers/platform/x86/asus-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index fc6446209854..a666fbc2e73b 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1148,7 +1148,7 @@ static void asus_als_switch(struct asus_laptop *asus, int value)
> ret = write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value);
> }
> if (ret)
> - pr_warning("Error setting light sensor switch\n");
> + pr_warn("Error setting light sensor switch\n");
>
> asus->light_switch = value;
> }
> --
> 2.20.1
>


--
With Best Regards,
Andy Shevchenko