Re: [PATCH v4 16/16] ftrace: Merge ftrace_module_{init,enable}()
From: Peter Zijlstra
Date: Fri Oct 18 2019 - 04:20:59 EST
On Fri, Oct 18, 2019 at 09:35:41AM +0200, Peter Zijlstra wrote:
> Because of how some architectures used set_all_modules_text_*() there
> was a dependency between the module state and its memory protection
> state. This then required ftrace to be split into two functions, see
> commit:
>
> a949ae560a51 ("ftrace/module: Hardcode ftrace_module_init() call into load_module()")
>
> Now that set_all_modules_text_*() is dead and burried, this is no
> longer relevant and we can merge the ftrace_module hooks again.
NOTE that by also getting rid of the ftrace_arch_code_modify_prepare() /
ftrace_arch_code_modify_post_process() callbacks in the
ftrace_module_enable() callback, both x86 and ARM will use direct poking
instead of doing the alias thing.