Re: [PATCH] xen/netback: fix error path of xenvif_connect_data()

[Wei Liu]

On Fri, Oct 18, 2019 at 09:45:49AM +0200, Juergen Gross wrote:
> xenvif_connect_data() calls module_put() in case of error. This is
> wrong as there is no related module_get().
> 
> Remove the superfluous module_put().
> 
> Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.12
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>

Reviewed-by: Wei Liu <wei.liu@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/interface.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 240f762b3749..103ed00775eb 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
>  	xenvif_unmap_frontend_data_rings(queue);
>  	netif_napi_del(&queue->napi);
>  err:
> -	module_put(THIS_MODULE);
>  	return err;
>  }
>  
> -- 
> 2.16.4
>