Re: [PATCH -next] btrfs: Make init_tree_roots static

From: Nikolay Borisov
Date: Fri Oct 18 2019 - 08:10:04 EST




On 18.10.19 Ð. 15:06 Ñ., YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/disk-io.c:2534:12: warning:
> symbol 'init_tree_roots' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Huhz, I thought I had added static... Anyway this could be folded in the
original patch. Thanks for the report.

> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d078276..cb187f5 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
> return ret;
> }
>
> -int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> +static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> {
> int backup_index = find_newest_super_backup(fs_info);
> struct btrfs_super_block *sb = fs_info->super_copy;
>