Re: [PATCH -next 11/30] pinctrl: msm: use devm_platform_ioremap_resource() to simplify code

From: Bjorn Andersson
Date: Fri Oct 18 2019 - 13:07:04 EST


On Thu 17 Oct 05:26 PDT 2019, YueHaibing wrote:

> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0b..62fcae9 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1150,8 +1150,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> return PTR_ERR(pctrl->regs[i]);
> }
> } else {
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pctrl->regs[0] = devm_ioremap_resource(&pdev->dev, res);
> + pctrl->regs[0] = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pctrl->regs[0]))
> return PTR_ERR(pctrl->regs[0]);
> }
> --
> 2.7.4
>
>