Re: [PATCH bpf-next] bpf: Fix build error without CONFIG_NET

[Yonghong Song]

On 10/18/19 2:03 AM, YueHaibing wrote:
> If CONFIG_NET is n, building fails:
> 
> kernel/trace/bpf_trace.o: In function `raw_tp_prog_func_proto':
> bpf_trace.c:(.text+0x1a34): undefined reference to `bpf_skb_output_proto'
> 
> Wrap it into a #ifdef to fix this.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Acked-by: Yonghong Song <yhs@xxxxxx>

> ---
>   kernel/trace/bpf_trace.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 52f7e9d..c324089 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -1055,8 +1055,10 @@ raw_tp_prog_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
>   	switch (func_id) {
>   	case BPF_FUNC_perf_event_output:
>   		return &bpf_perf_event_output_proto_raw_tp;
> +#ifdef CONFIG_NET
>   	case BPF_FUNC_skb_output:
>   		return &bpf_skb_output_proto;
> +#endif
>   	case BPF_FUNC_get_stackid:
>   		return &bpf_get_stackid_proto_raw_tp;
>   	case BPF_FUNC_get_stack:
>