clk: bcm2835: Checking a clk_register() call in bcm2835_clk_probe()

From: Markus Elfring
Date: Fri Oct 18 2019 - 14:43:09 EST


Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function âbcm2835_clk_probeâ contains still
an unchecked call of the member function âclk_registerâ.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/bcm/clk-bcm2835.c?id=7571438a4868e7cb09d698ab52e54f9722020eef#n2243
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/bcm/clk-bcm2835.c#L2243

How do you think about to improve it?

* Which error code would you like to return for a failed
clock registration at this place?

* Will it be needed to delete any information about clocks
as exception handling?

Regards,
Markus