Re: [BUGFIX PATCH 0/5] selftests: Fixes for 32bit arch

[shuah]

On 10/7/19 9:10 AM, Masami Hiramatsu wrote:
> Hi,
>
> Here are some patches to fix some warnings/issues on 32bit arch
> (e.g. arm).
>
> When I built the ksefltest on arm, I hit some 32bit related warnings.
> Here are the patches to fix those issues.
>
>
>   - [1/5] va_max was set 2^32 even on 32bit arch. This can make
>          va_max == 0 and always fail. Make it 3GB on 32bit.
>   - [2/5] Some VM tests requires 64bit user space, which should
>          not run on 32bit arch.
>   - [3/5] For counting the size of large file, we should use
>          size_t instead of unsinged long.
>   - [4/5] Gcc warns printf format for size_t and int64_t on
>          32bit arch. Use %llu and cast it.
>   - [5/5] Gcc warns __u64 and pointer type castings. It should
>          once translated to unsigned long.
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (5):
>        selftests: proc: Make va_max 3GB on 32bit arch
>        selftests: vm: Build/Run 64bit tests only on 64bit arch
>        selftests: net: Use size_t and ssize_t for counting file size
>        selftests: net: Fix printf format warnings on arm
>        selftests: sync: Fix cast warnings on arm
>
>
>   tools/testing/selftests/net/so_txtime.c            |    4 ++--
>   tools/testing/selftests/net/tcp_mmap.c             |    8 ++++----
>   tools/testing/selftests/net/udpgso.c               |    3 ++-
>   tools/testing/selftests/net/udpgso_bench_tx.c      |    3 ++-
>   .../selftests/proc/proc-self-map-files-002.c       |   11 ++++++++++-
>   tools/testing/selftests/sync/sync.c                |    6 +++---
>   tools/testing/selftests/vm/Makefile                |    5 +++++
>   tools/testing/selftests/vm/run_vmtests             |   10 ++++++++++
>   8 files changed, 38 insertions(+), 12 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>

Hi Masami,

I would love to pull these in. But looks like these are spread out
across several sub-systems.

There are some comments on vm patch. Do you mind sending them again
cc'ing everybody on the cover-letter. Looks like these are getting
lost in the noise.

thanks,
-- Shuah