Re: [RFT 1/3] power: supply: ab8500: Cleanup probe in reverse order

[Sebastian Reichel]

Hi,

On Wed, Oct 16, 2019 at 10:33:12AM +0200, Linus Walleij wrote:
> On Fri, Oct 4, 2019 at 5:07 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> 
> > It is logical to cleanup in probe's error path in reverse order to
> > previous actions.  It also makes easier to add additional goto labels
> > within this error path.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> 
> For all 3 patches:
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> The battery charging code is currently disabled on ux500 simply
> because no platforms with batteries were available for testing
> or supported by any device trees.
> 
> This is getting fix: PostmarketOS is brewing patches for enabling
> all Ux500-based Samsung phones, all with batteries. So we will
> soon be able to test and turn this on.
> 
> The patches are fine to merge, however notice that we are
> refactoring all drivers using ADC through the IIO tree:
> https://lore.kernel.org/linux-iio/20191011071805.5554-4-linus.walleij@xxxxxxxxxx/
> https://lore.kernel.org/linux-iio/20191011071805.5554-2-linus.walleij@xxxxxxxxxx/
> https://lore.kernel.org/linux-iio/20191011071805.5554-3-linus.walleij@xxxxxxxxxx/
> 
> It would be nice if we could avoid colissions.

Thanks, I merged your immutable branch for the ADC work
and this patchset.

-- Sebastian

Attachment: signature.asc
Description: PGP signature