Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

From: Joe Perches
Date: Mon Oct 21 2019 - 04:54:20 EST

On Mon, 2019-10-21 at 08:52 +0200, Julia Lawall wrote:
> > btw2:
> >
> > I really dislike all the code inconsistencies and
> > unnecessary code duplication with miscellaneous changes
> > in the rtl staging drivers....
> >
> > Horrid stuff.
> I'm not sure what you mean by "miscellaneous changes". Do you mean that
> all issues should be fixed for one file before moving on to another one?
> Or that there are code clones, and all of the clones should be updated at
> the same time?

Neither really.

But realtek drivers are basically code clones where
realtek should prefer to have a single library used
for multiple drivers.

And staging is basically a dumping ground for realtek
wireless drivers.